search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
17.5k stars 1.45k forks source link

fix(build): fix build-www rewriteImports to always rewrite flow modules #5995

Closed etrepum closed 2 weeks ago

etrepum commented 2 weeks ago

Description

rewriteImports regression caused some flow modules not to get rewritten. Working theory is that the in-place update only had an effect if a module was also rewritten, and some modules do not have dependencies (such as packages/lexical/dist/Lexical.js.flow)

Test plan

Before

build-www outputs some flow modules in dist without rewriting their comments

After

build-www outputs all flow modules in dist with rewritten comments

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:21pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 9:21pm
acywatson commented 2 weeks ago

let's try it!