search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
19.95k stars 1.7k forks source link

Table Action Menu - fix UI issue with Merge Cells item #6830

Closed umaranis closed 2 days ago

umaranis commented 1 week ago

Description

Describe the changes in this pull request

Closes ##6829

Test plan

Before

Insert relevant screenshots/recordings/automated-tests image

After

Insert relevant screenshots/recordings/automated-tests image

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:56am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:56am
github-actions[bot] commented 1 week ago

size-limit report 📦

Path Size
lexical - cjs 30.85 KB (0%)
lexical - esm 30.73 KB (0%)
@lexical/rich-text - cjs 39.58 KB (0%)
@lexical/rich-text - esm 32.67 KB (0%)
@lexical/plain-text - cjs 38.22 KB (0%)
@lexical/plain-text - esm 29.93 KB (0%)
@lexical/react - cjs 41.35 KB (0%)
@lexical/react - esm 34.03 KB (0%)
umaranis commented 3 days ago

I think the best fix here would be to wrap the button text with <span class="text">…</span> in the merge/unmerge buttons just like all of the other menu items that display correctly without this CSS change

Agree. Submitted the change on this PR. Thanks @etrepum