search

facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
19.95k stars 1.7k forks source link

Chore: Change default skipInitialization to false for registerMutationListener #6846

Open etrepum opened 3 days ago

etrepum commented 3 days ago

After #6357 the skipInitialization option to registerMutationListener was supposed to change to false. The deprecation period is long past, so it's time to change this default and the associated comments/docs.

Search for skipInitialization to find them all. Change only the docs and the default (DEFAULT_SKIP_INITIALIZATION), do not change any of the code that uses this option (it's already correct).

This change will prevent bugs like https://github.com/wobsoriano/lexical-vue/issues/66

Shopiley commented 2 days ago

Hi, can I take this up?

etrepum commented 1 day ago

Sure, go ahead

Shopiley commented 21 hours ago

should I change the comments as well or remove them?

image

e.g The default was previously true for backwards compatibility with <= 0.16.1 but this default is now changed to false in [current version]

etrepum commented 20 hours ago

Yes, use 0.21.0 as the version that it changed

Shopiley commented 12 hours ago

[like] Fadekemi ADEBAYO reacted to your message:

From: Bob Ippolito @.> Sent: Friday, November 22, 2024 12:09:01 AM To: facebook/lexical @.> Cc: Fadekemi ADEBAYO @.>; Mention @.> Subject: Re: [facebook/lexical] Chore: Change default skipInitialization to false for registerMutationListener (Issue #6846)

Yes, use 0.21.0 as the version that it changed

— Reply to this email directly, view it on GitHubhttps://github.com/facebook/lexical/issues/6846#issuecomment-2492603890, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATS3PP3D4YEYDYL6LS3PHGT2BZYZ3AVCNFSM6AAAAABSCS4GO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJSGYYDGOBZGA. You are receiving this because you were mentioned.Message ID: @.***>