facebook / lexical

Lexical is an extensible text editor framework that provides excellent reliability, accessibility and performance.
https://lexical.dev
MIT License
19.95k stars 1.7k forks source link

Feature: Deprecate $nodesOfType function #6855

Closed Sachin-Mahato closed 14 hours ago

Sachin-Mahato commented 1 day ago

Description

The $nodesOfType function was used to fix a problem with registerMutationListener. After the changes in #6357, registerMutationListener works fine, so $nodesOfType is no longer needed and caused bugs

This PR adds a feature to mark $nodesOfType as deprecated. It suggests using registerMutationListener instead. The goal is to remove old code and avoid bugs that can happen when using $nodesOfType.

Closes #6847

facebook-github-bot commented 1 day ago

Hi @Sachin-Mahato!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:56am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:56am
github-actions[bot] commented 1 day ago

size-limit report 📦

Path Size
lexical - cjs 30.94 KB (0%)
lexical - esm 30.8 KB (0%)
@lexical/rich-text - cjs 39.6 KB (0%)
@lexical/rich-text - esm 32.66 KB (0%)
@lexical/plain-text - cjs 38.2 KB (0%)
@lexical/plain-text - esm 29.92 KB (0%)
@lexical/react - cjs 41.37 KB (0%)
@lexical/react - esm 34 KB (0%)