facebook / litho

A declarative framework for building efficient UIs on Android.
https://fblitho.com
Apache License 2.0
7.71k stars 764 forks source link

feat(gap-support): Modified PostWithActionsKComponent and UserFeedWithStoriesKComponent to add some gaps #1024

Closed stevenkang90 closed 1 month ago

stevenkang90 commented 1 month ago

Summary

Gaps don't seem to be working as show in the sample app by manually adding gaps to the rows and columns in the list examples. Tracing the code through it seems the YogaNode does have the values set suggesting the result isn't being used but I'm not sure where the fix is. Any support would be appreciated.

Screenshot 2024-10-09 at 09 09 10

In terms of where I'd expect to see gaps, I'd expect to see a gap between the items in the first row and then between the elements in the root column.

Screenshot 2024-10-09 at 09 11 38

We want gap support against the latest version of Litho which also has fixes we need for item sizes in lazy lists.

Changelog

Test Plan