facebook / litho

A declarative framework for building efficient UIs on Android.
https://fblitho.com
Apache License 2.0
7.71k stars 764 forks source link

issue for ViewPagerComponent #1031

Open zhengzhong1 opened 2 weeks ago

zhengzhong1 commented 2 weeks ago

Version

0.47.0

Issues and Steps to Reproduce

litho ViewPagerComponent How to set height, like android's "wrap_content";

heightDip(-1) or heightPx(-1)

Setting the height equal to -1 does not seem to take effect;

flexGrow(1)

flexGrow method is effect,It will make the ViewPagerComponent fill the entire page, like android's match_parent

RecyclerCollectionComponent.Builder builder =RecyclerCollectionComponent

        .create(c)
        .flexGrow(1)
        .heightDip(-1)
        .heightPx(-1)
        .disablePTR(true)
        .section(
            ViewPagerHelperSection.<T>create(new SectionContext(c))
                .delegateSection(dataDiffSection)
                .pageSelectedEventEventHandler(
                    ViewPagerComponent.getPageSelectedEventHandler(c))
                .initialPageIndex(initialPageIndex))
        .eventsController(eventsController)
        .recyclerConfiguration(recyclerConfiguration);`

Expected Behavior

ViewPagerComponent height is determined by child layout height