RecyclerCollectionComponent doesn't support pull to refresh spinner offset

facebook / litho

A declarative framework for building efficient UIs on Android.

https://fblitho.com

Apache License 2.0

7.7k stars 764 forks source link

RecyclerCollectionComponent doesn't support pull to refresh spinner offset #534

Open wooyukit opened 5 years ago

wooyukit commented 5 years ago

[x] I have searched existing issues and this is not a duplicate

Version

0.25.0

Issues and Steps to Reproduce

RecyclerCollectionComponent doesn't support pull to refresh spinner offset

Expected Behavior

Allow me configuring the pull to refresh spinner offset position

muraziz commented 5 years ago

You mean, vertical offset or horizontal? Do you wanna send PR for that?

wooyukit commented 5 years ago

For android SwipeRefreshLayout, you can setProgressViewOffset api to define the spinner offset. But for litho recycler collection component, there is no property to configure.

Katalune commented 5 years ago

As @muraziz mentioned, I'd also suggest to send a PR for that.