search

facebook / litho

A declarative framework for building efficient UIs on Android.
https://fblitho.com
Apache License 2.0
7.71k stars 764 forks source link

Remove broken tests temporarily (#987) #988

Closed passy closed 5 months ago

passy commented 6 months ago

Summary:

The tests are not actually being run.

After upgrading the Gradle plugin on GitHub, it has become clear that these are running without the AP processing them. When processed, they raise some fairly obvious mistakes:

{P1221730610}

This is removing them for now so we can get the update and new release out.

Done using

pastry P1221730610 | rg -F '/src/' | awk '{print $1}' | cut -d ':' -f 1 | uniq | sed -e 's:/Users/realpassy/Projects/java/litho/::' | xargs hg rm -v

To restore the rests, let's do it one-by-one by doing hg revert -r 5ac836c8ff21bb798ce1aba47a47857f93f3d47c^ -- litho-it/path/to/test.java

Differential Revision: D56517990

Stack created with Sapling. Best reviewed with ReviewStack.

facebook-github-bot commented 5 months ago

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@passy has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 5 months ago

@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@passy merged this pull request in facebook/litho@9ddb59618c734791239d074bf8e1ffef6d66204c.