Open oguzy opened 6 years ago
Folly build is broken. Until it is fixed, I suggest using the most recent release build.
Which release is building without errors? I trier 38,37,36. None worked.
This is the error for release-38-0:
mv -f $depbase.Tpo $depbase.Po
/bin/bash ../../libtool --tag=CXX --mode=link g++-5 -std=gnu++1y -g -O2 -lboost_context -lboost_program_options -lboost_thread -lboost_filesystem -lboost_system -lboost_regex -lpthread -lboost_chrono -lssl -lcrypto -ljemalloc -o logging_example main.o libfollylogging_example.la -lz -ldl -levent -ldouble-conversion -lglog -lgflags
libtool: link: g++-5 -std=gnu++1y -g -O2 -o .libs/logging_example main.o ./.libs/libfollylogging_example.a /usr/local/mcrouter/pkgs/folly/folly/.libs/libfolly.so -lboost_context -lboost_program_options -lboost_thread -lboost_filesystem -lboost_system -lboost_regex -lpthread -lboost_chrono -lssl -lcrypto -ljemalloc -lz -ldl -levent -ldouble-conversion -lglog -lgflags -Wl,-rpath -Wl,/usr/local/mcrouter/install/lib
/usr/local/mcrouter/pkgs/folly/folly/.libs/libfolly.so: undefined reference to folly::CustomLogFormatter::CustomLogFormatter(folly::Range<char const*>, bool)' collect2: error: ld returned 1 exit status make[2]: *** [logging_example] Error 1 make[2]: Leaving directory
/usr/local/mcrouter/pkgs/folly/folly/logging/example'
make[1]: [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/mcrouter/pkgs/folly/folly'
make: [all] Error 2
diff --git a/mcrouter/scripts/common.sh b/mcrouter/scripts/common.sh index f997cd12..d5ff45fc 100644 --- a/mcrouter/scripts/common.sh +++ b/mcrouter/scripts/common.sh @@ -11,6 +11,7 @@ INSTALL_AUX_DIR="$3" shift $# MAKE_ARGS="$@" SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +folly_DIR=$PKG_DIR/folly
mkdir -p "$PKG_DIR" "$INSTALL_DIR"
happens for master branch