search

facebook / mcrouter

Mcrouter is a memcached protocol router for scaling memcached deployments.
MIT License
3.27k stars 540 forks source link

master is broken because of missing include ClientIdentifierHelper.h #453

Open rnurgaliyev opened 4 weeks ago

rnurgaliyev commented 4 weeks ago

2f32271533fdf54ce71cfb65f6fda3c621f076a4 added an include core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h in ServerOnRequest.h, which is probably internal to Facebook and not shipped anywhere.

sccache clang++-16 -DHAVE_CONFIG_H   -I..
-I/cfsetup_build/mcrouter/build/install/include
-DLIBMC_FBTRACE_DISABLE -DDISABLE_COMPRESSION
-Wno-missing-field-initializers -Wno-deprecated-declarations -W -Wall
-Wextra -Wno-unused-parameter -fno-strict-aliasing -std=c++20 -g -O2
-MT mcrouter-main.o -MD -MP -MF .deps/mcrouter-main.Tpo -c -o
mcrouter-main.o `test -f 'main.cpp' || echo './'`main.cpp
In file included from main.cpp:21:
In file included from ../mcrouter/StandaloneUtils.h:13:
In file included from ../mcrouter/Server.h:42:
In file included from ./Server-inl.h:23:
../mcrouter/ServerOnRequest.h:14:10: fatal error:
'core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h'
file not found
#include "core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h"
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[3]: *** [Makefile:2055: mcrouter-main.o] Error 1
mszabo-wikia commented 3 weeks ago

I fixed this in https://github.com/facebook/mcrouter/pull/449 which also aims to generally make the build more stable. Unfortunately it seems to be stuck in something of a limbo right now.