search

facebook / memlab

A framework for finding JavaScript memory leaks and analyzing heap snapshots
https://facebook.github.io/memlab/
MIT License
4.35k stars 118 forks source link

More recent Chrome version / Apple Silicon support #57

Closed eelco closed 1 year ago

eelco commented 1 year ago

Currently memlab is using a relatively old version of Puppeteer, which uses an old version of Chrome (101). It’s also running the Intel version on Apple Silicon macs, which likely is not helping performance when taking huge heap snapshots. (I’m writing this issue while waiting on a 1GB heap snapshot.)

Can this be upgraded to a more recent version?

JacksonGL commented 1 year ago

@eelco At the moment, memlab is using an older version of Puppeteer because the code is shared and used for internal testing at Meta and there are certain factors that lead to the use of the older version for now. We may update the code in the future to allow MemLab OSS to use the latest version of Puppeteer.

I tried using a local build with Puppeteer@19.4.1 + Chromium 109 to see if it would improve performance when taking heap snapshots, but I did not notice a significant speedup on my machine. I'm curious if you have experienced a different result on your machine.

eelco commented 1 year ago

Thanks for the clarification!

My issue is for two things:

I expect performance gains to come from the latter, but both require a more recent version of Puppeteer, which is why I created a single issue.

timocov commented 1 year ago

Looks like puppeteer has been upgraded in https://github.com/facebook/memlab/commit/872b30238f1728cbcdebfb9800d54972f8669d62