search

facebook / metro

🚇 The JavaScript bundler for React Native
https://metrobundler.dev
MIT License
5.24k stars 626 forks source link

fix: correctly format logs when saving bundle #1300

Closed szymonrybczak closed 4 months ago

szymonrybczak commented 5 months ago

Summary

When using community-cli-plugin, output when saving bundle looks like this:

❯ npx react-native bundle --platform android --entry-file index.js --dev=false --bundle-output dist/
                Welcome to Metro v0.80.9
              Fast - Scalable - Integrated

info Writing bundle output to:, dist/

There's a useless comma in log, because community-cli-plugin uses logger.info from @react-native-community/cli-tools which separates each item with , separator.

Test plan

Saving bundle output should contain correctly formatted log:

info Writing bundle output to: dist/
szymonrybczak commented 5 months ago

cc @huntie

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.80%. Comparing base (9b295e5) to head (6f86b48).

Files Patch % Lines
packages/metro/src/shared/output/bundle.flow.js 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1300 +/- ## ======================================= Coverage 83.80% 83.80% ======================================= Files 207 207 Lines 10883 10883 Branches 2733 2733 ======================================= Hits 9121 9121 Misses 1762 1762 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 5 months ago

@huntie has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@huntie merged this pull request in facebook/metro@2f1801a489cc656b9cd6ff90cad0ad8d33c0decd.