update babel and fix tests accordingly - Githubissues

facebook / metro

🚇 The JavaScript bundler for React Native

https://metrobundler.dev

MIT License

5.24k stars 626 forks source link

update babel and fix tests accordingly #1343

Closed vzaidman closed 2 months ago

vzaidman commented 2 months ago

Updated babel packages in package.json, removed yarn.lock files and recreated them by running yarn install also fixed the following:

Updated jest snapshot tests failing
Updated babel types and corrected typings accordingly:
- The latest babel 7 introduces the following features we need to adjust our types to:
- JSXNamespacedName is removed from valid CallExpression args (PR)
  - JSXNamespacedName is used for namespaced XML properties in things like <div namespace:name="value">, but fn(namespace:name) doesn't make any sense.
- Dynamic imports are enabled behind a new flag createImportExpressions (PR), introducing calls such as import(foo, options). These complicate the expected values passed to import to be more than just strings.
  - Since these are behind a flag that is not expected to be enabled, we can throw an error for now and whoever uses it can add a support to it if needed later.

Differential Revision: D61543660

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D61543660

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D61543660

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D61543660

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/metro@2c3a22ab69044b35b07d20c53a145b9c7cddf30e.