facebook / metro

🚇 The JavaScript bundler for React Native
https://metrobundler.dev
MIT License
5.24k stars 626 forks source link

feat: optimize getMaxWorkers using os.availableParallelism #1378

Closed screetBloom closed 3 weeks ago

screetBloom commented 3 weeks ago

Summary

Optimize the maximum number of worker parallelism using os.availableParallelism

os.cpus().length returns the number of CPUs in the physical device, which is static. It should be replaced with the maximum number of computations the system can execute simultaneously. In Node.js, this is provided by os.availableParallelism().

Currently, Metro requires Node.js version 18.18 or higher, which includes os.availableParallelism.

Test plan

Green CI

facebook-github-bot commented 3 weeks ago

Hi @screetBloom!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 3 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 3 weeks ago

@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

screetBloom commented 3 weeks ago

Additional notes:

  1. The current implementation of Math.max(1, Math.ceil(cores (0.5 + 0.5 Math.exp(-cores * 0.07)) - 1)) uses approximately 50%-60% of the CPU cores, which may not achieve the highest performance in CI deployments.

  2. I will try to design a method to set the optimal number of workers based on different CPU architectures in CI deployments soon. Maximize the use of all performance cores of the CI machine.

facebook-github-bot commented 3 weeks ago

@robhogan merged this pull request in facebook/metro@5ae946db8e1278395e86796d0ada8e2e57495848.