search

facebook / mvfst

An implementation of the QUIC transport protocol.
MIT License
1.5k stars 242 forks source link

Modified qlog serialization according to draft 02 #297

Closed dbaldassi closed 1 year ago

dbaldassi commented 1 year ago

Hi, I upgraded the qlog implementation to have the draft 02 format. qvis could not load congestion info and we couldn't visualize the cwnd and rtt. With this change, it can be visualized in qvis.

facebook-github-bot commented 1 year ago

Hi @dbaldassi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

lnicco commented 1 year ago

@dbaldassi thanks for this contribution. I'll import this PR internally for review. Note that due to internal dependencies on the QLOG format it may not be straightforward to just update like this until the dependencies are taken care of

facebook-github-bot commented 1 year ago

@lnicco has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.