Don't force STATIC for libraries

simonmar commented 1 year ago

Summary:

fbthrift recently picked up a dependency on mvfst/quic (D45366398)
hsthrift depends on fbthrift, and builds all its dependencies as shared libraries because that's what Haskell needs
mvfst forces STATIC for its libraries, which breaks the hsthrift build

/usr/bin/ld: quic/codec/libmvfst_codec_types.a(QuicConnectionId.cpp.o): relocation R_X86_64_PC32 against symbol `_ZZN5folly7hexlifyINS_5RangeIPKhEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEbRKT_RT0_bE9hexValues' can not be used when making a shared object; recompile with -fPIC

Forcing STATIC should be unnecessary, because BUILD_SHARED_LIBS defaults to NO, I believe.

Differential Revision: D47511897

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D47511897

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D47511897

facebook-github-bot commented 1 year ago

This pull request has been merged in facebookincubator/mvfst@a8a6dc643537615dc7a41c8411f10b91c4d37428.

facebook / mvfst

Don't force STATIC for libraries #302