search

facebook / mvfst

An implementation of the QUIC transport protocol.
MIT License
1.5k stars 242 forks source link

use system deps in github CI for mac and linux #330

Closed ahornby closed 8 months ago

ahornby commented 8 months ago

use system deps in github CI for mac and linux

speed up the github CI by not rebuilding boost every time

Regenerated tha actions with

./build/fbcode_builder/getdeps.py generate-github-actions --allow-system-packages --src-dir=. --os-type=darwin --output-dir=.github/workflows mvfst
./build/fbcode_builder/getdeps.py generate-github-actions --allow-system-packages --src-dir=. --os-type=linux --output-dir=.github/workflows mvfst

Test Plan:

CI

Stack created with Sapling. Best reviewed with ReviewStack.

ahornby commented 8 months ago

cc @jbeshay looks like this speeds up the github CI quite a lot

facebook-github-bot commented 8 months ago

@jbeshay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jbeshay commented 8 months ago

Looks like it's cutting down the Linux and Mac workflows by ~30%.

Thanks @ahornby for this and for the build fix too.

facebook-github-bot commented 8 months ago

@jbeshay merged this pull request in facebook/mvfst@cb42b717d0ab180922595a49e6cafaf10a2ce942.