search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Consider updating rocksdb/Makefile #1258

Open mdcallag opened 1 year ago

mdcallag commented 1 year ago

rocksdb/Makefile is hardwired to use -march=armv8+a+crc+crypto. That won't take advantage of features on modern ARM. A workaround is to use -march=native (works on gcc, not supported on ARM), -mcpu=native (should work on both). Alas, these options can limit portability of the resulting binary. Other possible values are here.

mdcallag commented 1 year ago

I encountered this while trying to explain perf differences for xxh3 between x86 and ARM. See here. But changing CXXFLAGS didn't fix that problem.

laurynas-biveinis commented 3 months ago

Apparently compiler flags are hard, see https://perconadev.atlassian.net/browse/PS-9034 (and https://perconadev.atlassian.net/browse/PS-8949 for macOS)