Index read fixes - Githubissues

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.48k stars 712 forks source link

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

Minor index access cleanups for MyRocks:

ha_rocksdb::index_init: remove duplicate active_index assignment. Move m_need_build_decoder assignment past the error exit so that taking it does not result in any state changes.
ha_rocksdb::index_next_same: add an assert for active_index value to prevent out-of-bound accesses in the next line.

hermanlee commented 1 year ago

Let me backport the first two patches directly, and then we can rebase this PR so that it contains only the MyRocks changes.

laurynas-biveinis commented 1 year ago

Right, I forgot about the squashing

laurynas-biveinis commented 1 year ago

Rebased, ready for review

facebook-github-bot commented 1 year ago

@hermanlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.