search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

force_flush_memtable_and_lzero_now always compacts to physical L1 #1295

Closed mdcallag closed 1 month ago

mdcallag commented 1 year ago

force_flush_memtable_and_lzero_now always compacts to the physical L1, which might not be in use when dynamic leveled is enabled. In that case it should compact to the logical L1, which might be the level named L2 or L3.

The buggy code, written by me, is here for 5.6.35 and 8.0.28.

Instead of "1" the argument to CompactFiles can be determined via a call to getProperty using the "rocksdb.base-level" property, or kBaseLevel. See here.

mdcallag commented 1 month ago

AFAIK the fix has been merged for FB MySQL 8.0.32