Closed sunshine-Chun closed 1 year ago
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
dict_manager is a static variable declared in ha_rocksdb.cc. The get/set server version call rely on this variable. However this variable is not accessible in rdb_native_dd. we can either make it global or we can wrap it in ha_rocksdb. (The current implementation). LMK your thoughts.
dict_manager is a static variable declared in ha_rocksdb.cc. The get/set server version call rely on this variable. However this variable is not accessible in rdb_native_dd. we can either make it global or we can wrap it in ha_rocksdb. (The current implementation). LMK your thoughts.
Wrapping LGTM
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Summary: This diff added support for set/get server version api in rocksdb
Test Plan: Test it locally
Reviewers:
Subscribers:
Tasks:
Tags: