search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Add set/get server version api #1296

Closed sunshine-Chun closed 1 year ago

sunshine-Chun commented 1 year ago

Summary: This diff added support for set/get server version api in rocksdb

Test Plan: Test it locally

Reviewers:

Subscribers:

Tasks:

Tags:

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

sunshine-Chun commented 1 year ago

dict_manager is a static variable declared in ha_rocksdb.cc. The get/set server version call rely on this variable. However this variable is not accessible in rdb_native_dd. we can either make it global or we can wrap it in ha_rocksdb. (The current implementation). LMK your thoughts.

laurynas-biveinis commented 1 year ago

dict_manager is a static variable declared in ha_rocksdb.cc. The get/set server version call rely on this variable. However this variable is not accessible in rdb_native_dd. we can either make it global or we can wrap it in ha_rocksdb. (The current implementation). LMK your thoughts.

Wrapping LGTM

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.