Open sunshine-Chun opened 1 year ago
Do we still need this diff. Sounds like we are not adding the. dd_space in the ddst_dict_init function now.
As with the rest of the current diffs, it's hard to say, as the code is too incomplete to run. IMHO we can hold until it becomes clear.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@laurynas-biveinis , according to previous conversation, we may still need this mysql tablespace. Currently https://github.com/facebook/mysql-5.6/pull/1319 will fail if there is testcase using rocksdb DD.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun , @luqun, It is true that we'll need the mysql tablespace. But, in the current prototype it is InnoDB that sets it up, thus at this point I am not comfortable to committing to RocksDB creating it. We could quickly merge a PR for ddse_dict_init
, which would be mostly empty, and leave the tablespace for later.
@sunshine-Chun , please close this PR
Summary: Add ddst_dict_init api support for rocksdb dd
Test Plan: Test locally, not crush....
Reviewers:
Subscribers:
Tasks:
Tags: