search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Add ddst_dict_init api support for rocksdb dd #1297

Open sunshine-Chun opened 1 year ago

sunshine-Chun commented 1 year ago

Summary: Add ddst_dict_init api support for rocksdb dd

Test Plan: Test locally, not crush....

Reviewers:

Subscribers:

Tasks:

Tags:

sunshine-Chun commented 1 year ago

Do we still need this diff. Sounds like we are not adding the. dd_space in the ddst_dict_init function now.

laurynas-biveinis commented 1 year ago

As with the rest of the current diffs, it's hard to say, as the code is too incomplete to run. IMHO we can hold until it becomes clear.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 1 year ago

@laurynas-biveinis , according to previous conversation, we may still need this mysql tablespace. Currently https://github.com/facebook/mysql-5.6/pull/1319 will fail if there is testcase using rocksdb DD.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

laurynas-biveinis commented 1 year ago

@sunshine-Chun , @luqun, It is true that we'll need the mysql tablespace. But, in the current prototype it is InnoDB that sets it up, thus at this point I am not comfortable to committing to RocksDB creating it. We could quickly merge a PR for ddse_dict_init, which would be mostly empty, and leave the tablespace for later.

laurynas-biveinis commented 10 months ago

@sunshine-Chun , please close this PR