Add rocksdb_is_supported_system_table api support for rocksdb dd

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.48k stars 712 forks source link

Add rocksdb_is_supported_system_table api support for rocksdb dd #1299

Closed sunshine-Chun closed 1 year ago

sunshine-Chun commented 1 year ago

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

sunshine-Chun commented 1 year ago

Can we merge this api to the code? PR https://github.com/facebook/mysql-5.6/pull/1287 is blocked without this api implemented. Without this api, the early_load_rocksdb_plugin.test will fail on the "mysql.password_history" because of the system table check inside of the engine check. I tried to return true for that table, it can pass the test. I will set a debug execute in the pr cited above to pass the mtr test.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

laurynas-biveinis commented 1 year ago

LGTM

sunshine-Chun commented 1 year ago

PR merged, close here.