Closed laurynas-biveinis closed 1 year ago
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.
Updated, ready for review
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
still waiting for test result and will update when it is done.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@bigfootjon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Various minor cleanups
All done or noticed in the native DD prototype work, are independent from it, and will help to reduce its diff.
ha_rocksdb::create_key_defs
had non-null attribute for the 2nd and 3rd argument. It seems that the attribute non-null arg indexes got desynced, because the 3rd argument is a reference, and by usage the 1st and the 2nd args are pointers that cannot benullptr
. Instead of fixing the attribute indexes, convert pointers to references, which cannot be null by design.ha_rocksdb::create_cfs
. At the same time maketbl_def_arg
const
, which previously was not, and make the function returnbool
, as it only returns two values for success and error. Convert it fromDBUG_ENTER_FUNC
/DBUG_RETURN
to a newer (and lighter)DBUG_TRACE
.ha_rocksdb::create_table
madeprivate
, pointer args converted to reference args.WriteBatch::SingleDelete
callsha_rocksdb::has_hidden_pk
madestatic
, args changed from pointers to references, removed redundantnonnull
attribute.ha_rocksdb::pk_index
args changed from pointers to references, removed redundantnonnull
attribute.ha_rocksdb::set_last_rowkey
argument was marked unused even though it was usedha_rocksdb::check_and_lock_sk
,ha_rocksdb::check_uniqueness_and_lock
,ha_rocksdb::update_write_row
,ha_rocksdb::reset
,ha_rocksdb::calc_updated_indexes
: added asserts for relationships between arguments andtable->record[0]
/table->record[1]
ha_rocksdb::adjust_handler_stats_sst_and_memtable
: reduce scope of two local varsRdb_key_def
: introduce invalid index ID constant based ondd::INVALID_OBJECT_ID
. Check it on construction and in the index ID getter. Replace direct field accesses with the getter call.Rdb_key_def::table_has_hidden_pk
arg changed from pointer to reference.warn_unused_result
attribute with the standard[[nodiscard]]
for all the touched signatures.