search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Move default PATH setting from CMake to get_rocksdb_files.sh #1312

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation.

The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself.

laurynas-biveinis commented 1 year ago

I tried reproducing the original issue with CentOS 9, GNU Make 4.3 on 8cc47c6b, but couldn't. Both current HEAD and ths commit build there fine for me too. Thus all I can say is that this change fixes the issue for me, and I hope it doesn't break in your environment.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.