search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Explicitly specify char signedness for the underlying enum type #1313

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

A plain 'char' without 'signed' or 'unsigned' may default to either one, depending on the platform. On x86_64 Linux it is signed, while on ARM Linux it is unsigned, resulting in a build error. Fix by explicitly marking it signed.

Squash with 295ba21bc021c0758ac4f6bb7c35b54ac5093012

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 1 year ago

could we just use default enum type int instead? I mean remove ": char "?

facebook-github-bot commented 1 year ago

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis commented 1 year ago

could we just use default enum type int instead? I mean remove ": char "?

Indeed it seems the users of the enum do not depend on the underlying type, I have update the PR to remove it.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

laurynas-biveinis commented 1 year ago

The PR has been merged with the new code but old commit message?