Closed laurynas-biveinis closed 1 year ago
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
could we just use default enum type int instead? I mean remove ": char "?
@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.
could we just use default enum type int instead? I mean remove ": char "?
Indeed it seems the users of the enum do not depend on the underlying type, I have update the PR to remove it.
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
The PR has been merged with the new code but old commit message?
A plain 'char' without 'signed' or 'unsigned' may default to either one, depending on the platform. On x86_64 Linux it is signed, while on ARM Linux it is unsigned, resulting in a build error. Fix by explicitly marking it signed.
Squash with 295ba21bc021c0758ac4f6bb7c35b54ac5093012