search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 712 forks source link

Refactor data dictionary transaction isolation setting #1316

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

InnoDB uses READ UNCOMMITTED, which is not supported with MyRocks. Instead of hardcoding READ UNCOMMITTED at several locations, introduce a helper function that returns the desired DD transaction isolation level, based on the default DD engine.

No functional changes if the default DD engine is InnoDB.

laurynas-biveinis commented 1 year ago

There are two commits but only the second one is for review. The first one will be removed once the prerequisite branch is merged.

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.