Refactor the acquisition of DDSE handlerton

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.48k stars 712 forks source link

Refactor the acquisition of DDSE handlerton #1319

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too.

No functional changes if default_dd_storage_engine == InnoDB.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 1 year ago

still work on update one MTR(rocksdb.early_load_rocksdb_plugin) according to this PR.

laurynas-biveinis commented 1 year ago

still work on update one MTR(rocksdb.early_load_rocksdb_plugin) according to this PR.

@luqun, I am sorry, I forgot that we already have an MTR test for DDSE == RocksDB. Do you need me to do anything at this point?