search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 712 forks source link

Remove extra assert in Rdb_writebatch_impl class #1337

Closed luqun closed 11 months ago

luqun commented 1 year ago

Rdb_writebatch_impl is used in replication if rocksdb_skip_trx_api = 1. thus it should have same behavior as Rdb_transaction_impl.

After MyRocks DD, these Rdb_writebatch_impl member function will be used to access DD table through attachable transaction which break these asserts.

Remove these asserts and keep same assert as Rdb_transaction_impl member functions

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 11 months ago

committed