facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 714 forks source link

update rocksdb suite MTR for rocksdb DD #1338

Closed luqun closed 1 year ago

luqun commented 1 year ago

Try to update all MTR in rocksdb suites to works on rocksdb DD.

Details:

Code changes:

MTR changes:

luqun commented 1 year ago

How are you testing these changes?

in mysql-test/suite/rocksdb/combinations, add following lines..so these testcase will run after upgrade DD from innodb to rocksdb

[rocksdb_dd] default_dd_storage_engine = 1

luqun commented 1 year ago

I should mention that the main purpose of this PR is to avoid duplicate effort.. @laurynas-biveinis and I both need to update some MTR for rocksdb DD..

laurynas-biveinis commented 1 year ago

I should mention that the main purpose of this PR is to avoid duplicate effort.. @laurynas-biveinis and I both need to update some MTR for rocksdb DD..

My DD changes focus on collecting new tests, as the ideal of always running all the tests with both DDSEs settings is unattainable. For example, https://github.com/laurynas-biveinis/mysql-5.6/commit/9f081c91e302ff0418e23d43b42eb3e8154d0c35: rocksdb.ddse, rocksdb_rpl.ddse_rpl

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.