Closed luqun closed 1 year ago
How are you testing these changes?
in mysql-test/suite/rocksdb/combinations, add following lines..so these testcase will run after upgrade DD from innodb to rocksdb
[rocksdb_dd] default_dd_storage_engine = 1
I should mention that the main purpose of this PR is to avoid duplicate effort.. @laurynas-biveinis and I both need to update some MTR for rocksdb DD..
I should mention that the main purpose of this PR is to avoid duplicate effort.. @laurynas-biveinis and I both need to update some MTR for rocksdb DD..
My DD changes focus on collecting new tests, as the ideal of always running all the tests with both DDSEs settings is unattainable. For example, https://github.com/laurynas-biveinis/mysql-5.6/commit/9f081c91e302ff0418e23d43b42eb3e8154d0c35: rocksdb.ddse, rocksdb_rpl.ddse_rpl
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Try to update all MTR in rocksdb suites to works on rocksdb DD.
Details:
Code changes:
MTR changes:
rocksdb large prefix: add a new large_prefix.test which is excluded from rocksdb DD, due to when rocksdb DD is enabled, rocksdb_large_prefix must be on.
rocksdb stats variables value change a lot when running under rocksdb DD, exclude rocksdb.bloomfilter, rocksdb.bloomfilter2., rocksdb.bloomfilter3, rocksdb.bloomfilter_bulk_load, rocksdb.read_only_tx from rocksdb DD combination
rocksdb doesn't support SERIALIZABLE ISOLATION, exclude rocksdb.issue314 from rocksdb DD combination
When restart mysqld with options, also pass default DDSE value to avoid accidentally change DD table from rocksdb->innodb or innodb->rocksdb