Fix MYSQL_BIN_LOG::update_prev_gtid_and_opid declaration

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.47k stars 712 forks source link

Fix MYSQL_BIN_LOG::update_prev_gtid_and_opid declaration #1343

Closed laurynas-biveinis closed 11 months ago

laurynas-biveinis commented 11 months ago

It was declared with long and defined with int64_t, causing

fb-mysql/sql/binlog.cc:6305:21: error: out-of-line definition of 'update_prev_gtid_and_opid' does not match any declaration in 'MYSQL_BIN_LOG' void MYSQL_BIN_LOG::update_prev_gtid_and_opid(Gtid_set *prev_gtid,

on macOS, where long != int64_t.

Squash with 10f0fe819b417767857146c0a6c5fa152f8e0238

laurynas-biveinis commented 11 months ago

ping @li-chi

li-chi commented 11 months ago

Nice catch

facebook-github-bot commented 11 months ago

@li-chi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.