[DD] add DD_ENGINE property into dd_properties table

luqun commented 10 months ago

Summary: With multiple DDSE support, DD tables can be stored in different DDSE.

During upgrade, it is possible that some of DD table is upgrade to target engine but others DD tables isn't. To skip check all of these tables SE, store DD_ENGINE value into dd_properties and the value is stored/updated at the end of upgrade.

if DD_ENGINE value is same as default ddse, upgrade has been finished.
if DD_ENGINE value isn't same as default ddse, continue upgrade from start.

Changes:

Add more diagnostic info, such as DDSE changes into mysqld log
is_dd_upgrade() will return true if either version upgrade or ddse upgrade(change)
DD_ENGINE value is stored at the end of upgrade, similar to mysqld_version

facebook-github-bot commented 10 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 10 months ago

@luqun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 10 months ago

@luqun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 10 months ago

@luqun has updated the pull request. You must reimport the pull request before landing.

luqun commented 10 months ago

Could you explain how the scenario in my first comment works?

I will add this information into https://github.com/facebook/mysql-5.6/pull/1354

luqun commented 10 months ago

The PR has been committed

facebook / mysql-5.6

[DD] add DD_ENGINE property into dd_properties table #1345