[DD] use actual DDSE during ddse upgrade scenario

luqun commented 10 months ago

Summary:

During boostrap, default_dd_storage_engine and actual DDSE is same;
During DDSE change(innodb->rocksdb or rocksdb->innodb), default_dd_storage_engine and actual DDSE aren't same. default_dd_storage_engine is the target(or expected) DDSE, actual DDSE is existing DDSE and was fetched from dd_properties tables.

The change:

use actual DDSE during upgrade(! opt_initialize) scenario.
always call INNODB handler API for innobase_dict_recover and innobase_dict_init unless INNODB is disabled. This is required for DDSE change --- need to access data in INNODB
call dict_set_server_version to store server version info
etc

laurynas-biveinis commented 10 months ago

https://github.com/facebook/mysql-5.6/pull/1357 duplicated some of the changes, will review to reconcile both PRs (and likely drop mine)

laurynas-biveinis commented 10 months ago

@luqun , is this ready for review?

luqun commented 10 months ago

@luqun , is this ready for review?

Yes. it is. :)

facebook-github-bot commented 10 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook / mysql-5.6