Closed luqun closed 9 months ago
@luqun , is this ready for review?
@luqun , is this ready for review? Yes. maybe I shouldn't force push?
@luqun , is this ready for review? Yes. maybe I shouldn't force push?
Force pushes are fine with me
@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
committed
Summary:
The change is to "upgrade" DD tables from innodb SE to rocksdb SE.
Steps for a DD table involving DDSE change: apply to all DD tables
Workflow for innodb SE to rocksdb SE changes
The above workflow for INNODB->ROCKSDB DDSE change is finished with two writebatch commit first and one transaction commit
One transaction: it hold create tables, "rename" table, "logical copy" and committed in update_versions()
Whether to do DDSE change is controlled by 3 DDSE values:
If V1, V2, V3 are equal, then SKIP DD table change; otherwise, try DD table change
During DDSE change, if crash occurs, what's next?
Crash Scenarios during INNODB->ROCKSDB DDSE change
Remaining issues: