Cleanup pointers in method signatures called from ha_rocksdb::create_…

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.48k stars 714 forks source link

Cleanup pointers in method signatures called from ha_rocksdb::create_… #1355

Closed laurynas-biveinis closed 1 year ago

laurynas-biveinis commented 1 year ago

…key_defs

Refactoring with no behavior changes:

Whenever a pointer argument must be non-null, replace it with a lvalue or rvalue reference. Drop any asserts testing non-nullness, and nonnull attributes.
At the same time drop any redundant const qualifiers from scalar parameters
At the same time replace any warn_unused_result attributes with nodiscard, and add some extra ones.

facebook-github-bot commented 1 year ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 1 year ago

most change looks okay. for these non-const pointer to reference change, previously linter may complain "Is this a non-const reference? If so, make const or use a pointer".. with google c++ style change, now it allows non-const reference as parameter(https://github.com/google/styleguide/commit/7a7a2f510efe7d7fc), maybe our codebase can also use latest google c++ style change..

luqun commented 1 year ago

@laurynas-biveinis , Current PR has been pushed.