search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 712 forks source link

Remove an incorrect assert from MYSQL_BIN_LOG::prepare #1356

Closed laurynas-biveinis closed 10 months ago

laurynas-biveinis commented 10 months ago

It fires on MyRocks DDSE setup, whenever binlog is enabled globally, but turned off at the moment in one thread.

This is fixed in upstream 8.0.32: https://github.com/laurynas-biveinis/mysql-5.6/commit/c1401ada9b17ecddbbf71706e886f162cff1a37a

luqun commented 10 months ago

Could you add commit hash in upstream 8.0.32?

laurynas-biveinis commented 10 months ago

Could you add commit hash in upstream 8.0.32?

Sure, even though it's missing from the PR description, I have added it already to the commit message by a force push

facebook-github-bot commented 10 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.