facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 712 forks source link

Run clang-format on storage/rocksdb #1359

Closed laurynas-biveinis closed 10 months ago

laurynas-biveinis commented 10 months ago

Since it touched one of the lines with these debugging sync points, use this opportunity to fix "stimulate/simulate" typo too.

laurynas-biveinis commented 10 months ago

It is less than ideal to make a formatting-only PR, but tools complained all the time and

  void remove_from_global_trx_list(void) {
    DBUG_EXECUTE_IF("rocksdb_trx_list_crash", {
      if (!m_thd->is_system_thread() &&
          !m_thd->is_attachable_transaction_active()) {
        THD *thd = new THD();
      thd->thread_stack = reinterpret_cast<char *>(&(thd));

crossed the threshold for me

facebook-github-bot commented 10 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 10 months ago

I had thought we had done this before. let's test it in CI

laurynas-biveinis commented 10 months ago

This is clang-format 16. Let me know if you are using a different version

luqun commented 10 months ago

This is clang-format 16. Let me know if you are using a different version

we use an old version and it doesn't complain your change. so we should be good to go.