search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.48k stars 714 forks source link

Fb mysql 8.0.28 clone plugin autotune #1369

Closed sunshine-Chun closed 12 months ago

sunshine-Chun commented 1 year ago

This is a fix for the overshooting upstream bug. The active_task is calculated in a wrong way. In the current calculation, the active_task will always be 1 and the task_target will be always equal to target_speed, which will lead up to the case that all threads use their max bandwidth. (No throttling at all). The fix is to change the active_task to the number of threads, since all threads should be running and active.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 year ago

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 year ago

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

laurynas-biveinis commented 12 months ago

@sunshine-Chun, please close the PR