facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 712 forks source link

Update or skip some MTR tests for MyRocks DDSE, part 3 #1371

Closed laurynas-biveinis closed 9 months ago

laurynas-biveinis commented 9 months ago

The perfschema tests concern performance_schema sum_rows_updated columns in various tables. InnoDB detects when a row update does not actually need to update anything and returns HA_ERR_RECORD_IS_THE_SAME, and MyRocks does not, resulting in sum_rows_updated differences on DDL with different DDSE setting. Adjust esms_by_all and perfschema_periodic_snapshot_debug not to query sum_rows_updated at all, as neither replace_value nor replace_regex could handle different values well enough. For statements_row_updated, accept either value depending on what is the DDSE.

Skip innodb.innodb and innodb.innodb_misc1 because both test construct CREATE TABLE ... SELECT ... FROM a locked table, executed twice in parallel, returning different locked table errors.

facebook-github-bot commented 9 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 9 months ago

committed