facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.47k stars 711 forks source link

Allow unsupported transaction isolation levels for DD operations #1384

Closed laurynas-biveinis closed 7 months ago

laurynas-biveinis commented 8 months ago

If the current transaction isolation level is lower than READ COMMITTED, or higher than REPEATABLE READ, allow it silently if it's a DD operation. The rest of MyRocks code will work by silently clamping to the nearest supported level, and the clamped level is good enough for DD operations. InnoDB has similar code, even though it supports the other isolation levels.

laurynas-biveinis commented 8 months ago

This PR contains ~~https://github.com/facebook/mysql-5.6/pull/1381 and~~ ddse.test from https://github.com/facebook/mysql-5.6/pull/1383, to which it appends. These PRs should be merged first

facebook-github-bot commented 8 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 8 months ago

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis commented 8 months ago

@luqun, rebased. #1381 dependency is dropped but #1383 dependency remains

facebook-github-bot commented 8 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 8 months ago

@luqun, rebased. #1381 dependency is dropped but #1383 dependency remains

1383 also committed.

facebook-github-bot commented 8 months ago

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis commented 8 months ago

@luqun rebased, added a table_share != nullptr assert. All dependencies dropped now.

facebook-github-bot commented 8 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.