search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 711 forks source link

Do clangd-suggested include fixes in storage/rocksdb #1401

Closed laurynas-biveinis closed 3 months ago

laurynas-biveinis commented 7 months ago

To reduce the number of annoying wiggles under headers in the editor. Appears to be a net removal, which is good.

This is like include-what-you-use but less thorough, i.e. some #include <string> etc. are clearly missing but not suggested. https://clangd.llvm.org/guides/include-cleaner

facebook-github-bot commented 7 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 6 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 4 months ago

could you try compile with -DROCKSDB_CUSTOM_NAMESPACE=my_rocksdb

facebook-github-bot commented 4 months ago

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis commented 4 months ago

@luqun , rebased, handled new code, fixed the custom namespace issues

facebook-github-bot commented 4 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 4 months ago

one MTR failed, is it possible related this change?

[ 67%] main.percona_slowlog_size_limits 'innodb_intrinsic_table' w11 [ retry-fail ] Test ended at 2024-03-04 00:48:19

CURRENT_TEST: main.percona_slowlog_size_limits mysqltest: At line 41: Test assertion failed in assert_number_of_files.inc In included file ./include/assert_number_of_files.inc: 42 included from mysql-test/t/percona_slowlog_size_limits.test: 35

laurynas-biveinis commented 4 months ago

one MTR failed, is it possible related this change? [ 67%] main.percona_slowlog_size_limits 'innodb_intrinsic_table' w11 [ retry-fail ] Test ended at 2024-03-04 00:48:19

I cannot guarantee, but highly unlikely it's related to this PR. That test fails for me locally without it too.

facebook-github-bot commented 3 months ago

This pull request has been merged in facebook/mysql-5.6@19db3e88953b07af0105be2c449b112615142002.