Do not pass skip_unique_check flag as method argument

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.47k stars 711 forks source link

Do not pass skip_unique_check flag as method argument #1404

Closed laurynas-biveinis closed 7 months ago

laurynas-biveinis commented 7 months ago

Its value is duplicated with row_info.skip_unique_check, which is already passed to the same methods. At the same time replace MY_ATTRIBUTE((unused)) with [[nodiscard]].

facebook-github-bot commented 7 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.