Support mysql.db system table in MyRocks engine

[laurynas-biveinis]

• Allow mysql.db as a system table in MyRocks storage engine.
• Allow updates to ACL tables (which mysql.db is considered to be one of) in non-ROW binlog formats.
• Implement WL#14087 (Avoid locking reads from ACL tables) by honoring HA_EXTRA_NO_READ_LOCKING handler flag. It is done by a new handler flag, m_no_read_locking, which is checked in ha_rocksdb::external_lock together with the table category to downgrade RocksDB read locks to no locking at all.
• Adjust system tables script to create / alter mysql.db in the right engine depending on the default_dd_system_storage_engine setting.
• Add MTR regression tests to rocksdb suite with a sys_tables prefix.
• Adjust several tests to run with either system table engine.
• New MTR include file have_innodb_system_tables.inc, annotate several tests with it that have unmasked output difference depending on the system table storage engine.

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[luqun]

Thanks for adding WL#14087. do you happen to know why innodb doesn't need is_acl_table(table)? such as

if (m_prebuilt->table->is_dd_table || m_prebuilt->no_read_locking || is_acl_table(table)) {

https://github.com/facebook/mysql-5.6/blob/fb-mysql-8.0.32/storage/innobase/handler/ha_innodb.cc#L19054

[laurynas-biveinis]

do you happen to know why innodb doesn't need is_acl_table(table)? such as

if (m_prebuilt->table->is_dd_table || m_prebuilt->no_read_locking || is_acl_table(table)) {

https://github.com/facebook/mysql-5.6/blob/fb-mysql-8.0.32/storage/innobase/handler/ha_innodb.cc#L19054

ACL tables get extra(HA_EXTRA_NO_READ_LOCKING) called beforehand, this gets checked in the assert right above those lines: ut_ad(!m_prebuilt->no_read_locking || m_prebuilt->table->is_dd_table || is_acl_table(table));

I believe MyRocks logic here is an exact copy but written differently, MyRocks does not do the equivalent of is_acl_table at this point neither, except in an assert

[facebook-github-bot]

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

[laurynas-biveinis]

Rebased, addressed the first comment, the 2nd comment still open

[facebook-github-bot]

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

[laurynas-biveinis]

@luqun , updated with index ID masking, ready for review

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

This pull request has been merged in facebook/mysql-5.6@74cd3c832ddd1460259d3b91d663274a38a38a7b.