search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 711 forks source link

Make my_checksum.h include headers it uses #1418

Closed laurynas-biveinis closed 6 months ago

laurynas-biveinis commented 6 months ago

This fixes, on Linux on ARM:

In file included from /home/laurynas/vilniusdb/fb-mysql/_build-debug-llvm-12/include/installed_headers.cc:2: /home/laurynas/vilniusdb/fb-mysql/include/my_checksum.h:94:5: error: call to function 'memcpy' that is neither visible in the template definition nor found by argument-dependent lookup
    memcpy(&pv, buf, sizeof(PT));
    ^
/home/laurynas/vilniusdb/fb-mysql/include/my_checksum.h:119:21: note: in instantiation of function template specialization 'mycrc32::PunnedCrc32<unsigned long>' requested here
    return mycrc32::PunnedCrc32<std::uint64_t>(crc, pos, length);
                    ^
/usr/include/string.h:43:14: note: 'memcpy' should be declared prior to the call site extern void *memcpy (void *__restrict __dest, const void *__restrict __src,
             ^

Squash with 12c04a015cf2bd5f2c6c7bd2b17ecaf03ef0a53a

facebook-github-bot commented 6 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 6 months ago

This pull request has been merged in facebook/mysql-5.6@2b979289ae3f573f166519cb0ac660fe9c7d5d32.