search

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.47k stars 711 forks source link

Fix recent macOS build regression on test_bypass_rpc_plugin #1419

Closed laurynas-biveinis closed 5 months ago

laurynas-biveinis commented 6 months ago

Use PRIu64 to format uint64_t values to fix:

plugin/test_bypass_rpc_plugin/test_bypass_rpc_plugin_info.cc:502:28: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat]
  501 |         "calling bypass_select with query '%s', hlc_lower_bound_ts %lu",
      |                                                                    ~~~
      |                                                                    %llu
  502 |         query_str.c_str(), hlc_lower_bound_ts);
      |                            ^~~~~~~~~~~~~~~~~~
include/mysql/components/services/log_builtins.h:838:66: note: expanded from macro 'LogPluginErrMsg'
  838 |       .message_quoted("Plugin " LOG_COMPONENT_TAG " reported", ##__VA_ARGS__)
      |                                                                  ^~~~~~~~~~~
facebook-github-bot commented 6 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/mysql-5.6@fa6b066883f2eb5e2c0ff978fc6ec9638c0f3c69.