facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.46k stars 711 forks source link

Reimplement "show_dropped_column" debug injection in InnoDB server DD… #1425

Closed laurynas-biveinis closed 5 months ago

laurynas-biveinis commented 5 months ago

…-based I_S

The INFORMATION_SCHEMA InnoDB view reimplementation using server level-APIs did not reimplement "show_dropped_column" debug injection point. This caused several failures in --mysqld=--default-dd-system-storage-engine=ROCKSDB testing: innodb_zip.transportable_tbsp_debug_zip, innodb.instant_ddl_basic_debug, innodb.instant_ddl_import_debug, innodb.instant_ddl_import_partition_debug, innodb.instant_ddl_misc, innodb.instant_ddl_recovery_debug, innodb.instant_ddl_rollback_debug, and innodb.instant_ddl_update_debug.

Fix by adding this injection point in the server API-based implementation. Add one regression testcase to rocksdb_dd_innodb suite.

facebook-github-bot commented 5 months ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/mysql-5.6@34d350bbde01fa0c3c342c83fea0228ceddeeba1.