Support all of the system tables (except mysql.gtid_executed) in MyRocks

[laurynas-biveinis]

• Move rocksdb_is_supported_system_table from rdb_native_dd.cc to ha_rocksdb.cc because system tables are not DD tables
• Dropped the ability to create the replication status tables in MyISAM
• Adapt main.wl14965, main.component_debug, & binlog.binlog_half_crash_safe_ddl tests to run with either system table engine
• Convert main.roles-upgrade to an include file, and create a MyRocks version of the test (rocksdb.sys_tables_roles-upgrade)
• Likewise for main.plugin_auth, whose MyRocks version is rocksdb.sys_tables_plugin_auth.
• Likewise for main.mysql_upgrade_slave_master_info, whose MyRocks version is rocksdb.sys_tables_mysql_upgrade_slave_master_info.
• Only run rocksdb_rpl.rpl_rocksdb_max_row_locks test with InnoDB as the sys table engine due to row locks being taken by the system tables, making their number in MyRocks less predictable. This might be adjusted later by increasing the row lock limit and the test workload size.
• Re-record rocksdb_dd_innodb.known_directory, rocksdb_dd_innodb.innodb_zip_8k, rocksdb_dd_innodb.innodb_tablespace, rocksdb_dd_innodb.create_tablespace_debug, rocksdb_dd_innodb.create_tablespace_64k, rocksdb_dd_innodb.create_tablespace_32k, rocksdb.sys_tables_mysqlcheck, rocksdb.sys_tables_is_statistics_mysql, rocksdb.sys_tables_acl_tables_row_locking, & rocksdb.sys_tables tests.

[laurynas-biveinis]

@luqun , this is a draft PR before I leave for the PTO. There are test failures which I haven't analyzed yet: rocksdb_dd_innodb.virtual_basic rocksdb_clone.remote_dml_gtid rocksdb.sys_tables_transactional_acl_tables

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

[laurynas-biveinis]

@luqun , ready for review

[facebook-github-bot]

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[luqun]

also what's difference between rocksdb MTR test suites and rocksdb_dd_innodb MTR test suites? Previous I think rocksdb_dd_innodb MTR test suites is for innodb testcases runs under rocksdb DD, but now looks like some MTRs under rocksdb test suites also has similar pattern.

[laurynas-biveinis]

also what's difference between rocksdb MTR test suites and rocksdb_dd_innodb MTR test suites? Previous I think rocksdb_dd_innodb MTR test suites is for innodb testcases runs under rocksdb DD,

This is correct.

but now looks like some MTRs under rocksdb test suites also has similar pattern.

Which ones?

[luqun]

but now looks like some MTRs under rocksdb test suites also has similar pattern.

Which ones?

such as mysql-test/suite/rocksdb/t/sys_tables_mysql_upgrade_slave_master_info.test

[laurynas-biveinis]

but now looks like some MTRs under rocksdb test suites also has similar pattern.

Which ones?

such as mysql-test/suite/rocksdb/t/sys_tables_mysql_upgrade_slave_master_info.test

This is not an InnoDB-specific test, rather it was one of the general tests that regressed with a different DDSE

[facebook-github-bot]

This pull request has been merged in facebook/mysql-5.6@62658bc425c22bd21ce10914357eaad1d3966d8a.