facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.
http://myrocks.io
Other
2.46k stars 711 forks source link

Cleanup Rdb_transaction::m_is_tx_flag #1452

Closed laurynas-biveinis closed 1 month ago

laurynas-biveinis commented 2 months ago
laurynas-biveinis commented 2 months ago

This fell out from debugging range locking snapshot ignore start and stop points for DML statements, and will be a dependency PR for the range locking.

laurynas-biveinis commented 2 months ago

Havin slept on this, I don't like that the flag is set for two cases but read only for one of them. Let's try reducing its setting to the one case, and maybe the reset code will become simpler too.

laurynas-biveinis commented 2 months ago

Even better, it should be possible to remove the flag altogether

laurynas-biveinis commented 1 month ago

Superseded by https://github.com/facebook/mysql-5.6/pull/1453