ha_rocksdb.cc cleanups to minimize sysvar split diff

facebook / mysql-5.6

Facebook's branch of the Oracle MySQL database. This includes MyRocks.

http://myrocks.io

Other

2.46k stars 711 forks source link

Open laurynas-biveinis opened 2 weeks ago

laurynas-biveinis commented 2 weeks ago

Move #include directives to the right places.
Factor out repeated THDVAR & ha_thd calls, & current_thd reads.
Use the C++11 range for loop in one place, use auto more for local variable declarations, add assert(false) to one can't-happen branch.
Reformat the source file.

facebook-github-bot commented 1 week ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

luqun commented 1 week ago

Hi @laurynas-biveinis, could you rebase this PR?

facebook-github-bot commented 1 week ago

@laurynas-biveinis has updated the pull request. You must reimport the pull request before landing.

laurynas-biveinis commented 1 week ago

Hi @laurynas-biveinis, could you rebase this PR?

Sure @luqun, rebased

facebook-github-bot commented 1 week ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 hour ago

@luqun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.