facebook / opaque-ke

An implementation of the OPAQUE password-authenticated key exchange protocol
Apache License 2.0
291 stars 41 forks source link

Test P-521 #349

Closed daxpedda closed 9 months ago

daxpedda commented 10 months ago

This adds testing of P-521 through the p521 crate.

Still requires:

See #290 for a previously similar addition. See https://github.com/facebook/voprf/pull/127 for the same PR in voprf, which isn't required to merge this.

daxpedda commented 10 months ago

CI fails because of https://github.com/RustCrypto/elliptic-curves/issues/965, which we are going to wait for anyway.

daxpedda commented 10 months ago

This is ready to merge now.

kevinlewi commented 10 months ago

It seems like the maintenance for full_test.rs is getting more and more cumbersome now... any thoughts for how we can make this simpler?

And maybe for now, can you also add (in a comment above each new set of constants in full_test.rs) instructions for the cargo command to re-generate those constants?

daxpedda commented 9 months ago

Last two commits should address both concerns. WDYT?